Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Use posix API in module net and base #3966

Closed
wants to merge 2 commits into from
Closed

WIP: Use posix API in module net and base #3966

wants to merge 2 commits into from

Conversation

maxz-lab
Copy link
Contributor

b/302741384

@maxz-lab maxz-lab force-pushed the maxz-sb16-sock-posix-reuse branch 4 times, most recently from d1ebc65 to 5ab5b29 Compare August 13, 2024 19:14
@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Aug 13, 2024 •
edited
Loading

Datadog Report

Branch report: maxz-sb16-sock-posix-reuse
Commit report: 6594b6a
Test service: cobalt

✅ 0 Failed, 34358 Passed, 6 Skipped, 10m 29.17s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • ClientGetLocalPeerAddresses - UDPSocketTest - Last Failure

    Expand for error 
     ../../net/socket/udp_socket_unittest.cc:617
 Expected equality of these values:
   remote_address
     Which is: [2001:db8::42]:80
   fetched_remote_address
     Which is: 
 Google Test trace:
 ../../net/socket/udp_socket_unittest.cc:584: Connecting from ::1 to 2001:db8:0::42

@maxz-lab maxz-lab force-pushed the maxz-sb16-sock-posix-reuse branch 2 times, most recently from 8deed51 to 11000d7 Compare August 14, 2024 15:32
@maxz-lab
WIP: Use posix API in module net and base
885cbbc 
cobalt build link error under third_party
   Renamed namespace logging to mini_chromium_base_logging
   Renamed namespace base to mini_chromium_base

SB16 cobalt calls MessagePumpLibevent::Attach() which doesn't exist

b/302741384
@maxz-lab maxz-lab closed this Sep 12, 2024
@maxz-lab maxz-lab deleted the maxz-sb16-sock-posix-reuse branch September 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxz-lab